Koozali.org: home of the SME Server

Obsolete Releases => SME Server 7.x => Topic started by: Smitro on November 14, 2006, 01:55:04 PM

Title: Bug in Horde. How to patch?
Post by: Smitro on November 14, 2006, 01:55:04 PM

Hi all,

One of my users alerted my to a bug in horde, I have managed to find the fix for it in horde's bug tracker, but I don't know how to apply the fix. Can some one help me out? I presume that everyone may have this problem?

This is the reported bug.
http://bugs.horde.org/ticket/?id=2897&action=history

For me the problem seems to occurs when the attachements are .tif files, but not for every email, just some.

Title: Bug in Horde. How to patch?
Post by: warren on November 14, 2006, 08:02:19 PM

Smitro,

Download the patch file.

imp_images_php.diff

move  the imp_images_php.diff to the directroy where images.php is located.

cd to the directory containing images.php
# cp images.php   images.php.original

# patch  images.php    imp_images_php.diff


warren

Title: Bug in Horde. How to patch?
Post by: byte on November 14, 2006, 08:05:03 PM

Smitro - Can you open a Bug Report and attache the URL to the fix as it may be something the core devs need to decide fixing.

warren - That won't work because the file is made of templates so next time you reboot the changes will be gone.

Title: Bug in Horde. How to patch?
Post by: Smitro on November 14, 2006, 09:25:17 PM

Something that got me stuck, the file that I'd be replacing is is heaps longer than the one on the page. So I'm not sure if it's just suppose to be appended to the end or some where in between. Unfortunately the page isn't all that helpful.

I'll create a bug report.

Thanks.

Title: Bug in Horde. How to patch?
Post by: william_syd on November 14, 2006, 10:24:50 PM

Quote from: "byte"

warren - That won't work because the file is made of templates so next time you reboot the changes will be gone.

Can you confirm this..?

Title: Bug in Horde. How to patch?
Post by: william_syd on November 14, 2006, 10:26:59 PM

Quote from: "Smitro"

Something that got me stuck, the file that I'd be replacing is is heaps longer than the one on the page. So I'm not sure if it's just suppose to be appended to the end or some where in between. Unfortunately the page isn't all that helpful.

I'll create a bug report.

Thanks.

You not replacing the original file. You are changing it.

In this case you will be deleting one line and adding five lines.

Title: Bug in Horde. How to patch?
Post by: Smitro on November 14, 2006, 11:06:55 PM

this is my first attempt at adding a bug report, so hopefully I did it right.

http://bugs.contribs.org/show_bug.cgi?id=2067

Quote from: "william_syd"

You not replacing the original file. You are changing it.

I just re-read that last command "patch" I thought you said replace. My bad.

I wouldn't think it would be replaced by the templates as it's not a config file it's part of horde. I'll try to to patch it tonight and see if it fixes it.

Title: Bug in Horde. How to patch?
Post by: william_syd on November 14, 2006, 11:40:03 PM

Quote from: "Smitro"

this is my first attempt at adding a bug report, so hopefully I did it right.

http://bugs.contribs.org/show_bug.cgi?id=2067

Did you provide a link to the horde bug tracker ?
Edit: opps.. I see it now.. in the url section.

Quote from: "Smitro"

I wouldn't think it would be replaced by the templates as it's not a config file it's part of horde. I'll try to to patch it tonight and see if it fixes it.

It is possible for any config file for any installed software to be templated.