Koozali.org: home of the SME Server

Obsolete Releases => SME 7.x Contribs => Topic started by: MasterSleepy on May 13, 2008, 09:18:19 AM

Title: [ANNOUNCE] smeserver-system_monitor
Post by: MasterSleepy on May 13, 2008, 09:18:19 AM
Hello all,

A new version of system monitor is available.

This new version use rrdtool 1.2.
Thanks to sibsib for his modification.

RPM:
smeserver-system_monitor-1.1-1.noarch.rpm (http://www.vanhees.cc/index.php?name=CmodsDownload&file=index&req=viewdownloaddetails&lid=300)

sRPM:
smeserver-system_monitor-1.1-1.src.rpm (http://www.vanhees.cc/index.php?name=CmodsDownload&file=index&req=viewdownloaddetails&lid=301)

Wiki page have also been modified
http://wiki.contribs.org/SystemMonitor (http://wiki.contribs.org/SystemMonitor)

Regards,
MasterSleepy.
Title: Re: [ANNOUNCE] smeserver-system_monitor
Post by: mdo on May 13, 2008, 11:46:55 AM
MasterSleepy,

With all respect for your work on SME contribs - why do you split your smeserver-system_monitor development from the existing smeserver-sysmon?

As I understand it, your smeserver-system_monitor contrib's code comes very close to the existing smeserver-sysmon. Why do you spend your time on developing a copy rather then working together on one system monitor?

Michael
Title: Re: [ANNOUNCE] smeserver-system_monitor
Post by: MasterSleepy on May 13, 2008, 12:30:07 PM
Hello Michael,

You are right, system monitor is really close sysmon, because it use version 4.1-1 of sysmon.
The problem appear when sysmon appear in smecontrib repo.
To prevent my work I have to rebrand the contrib, with all lost of time that can cause.
The problem is also that procedure to acces dev environnement are really complexe, and I don't have time to spend AGAIN to that kind of manipulation.

Regards,
MasterSleepy.
Title: Re: [ANNOUNCE] smeserver-system_monitor
Post by: cactus on May 13, 2008, 12:43:39 PM
You are right, system monitor is really close sysmon, because it use version 4.1-1 of sysmon.
The problem appear when sysmon appear in smecontrib repo.
To prevent my work I have to rebrand the contrib, with all lost of time that can cause.
I tend to think that you did not do most of the work, but extended the contrib a little bit as your code does not difference that much from the original code now in SME Contribs. Rebranding is not a good option IMHO.

The problem is also that procedure to acces dev environnement are really complexe, and I don't have time to spend AGAIN to that kind of manipulation.
If you do not have time to set up a development environment against SME Contribs CVS you could suggest changes and patches per the bugtracker as additions are welcomed by the developers, instead of reinventing the wheel, once you have setup the development environment, which really is not that hard (I am willing to help you get there) and does not take that much time. You only need need some time to get your account working and to learn a few basic commands for the scource code management system, since you already now the source and the mechanism of patching in RPM's.

I think it is better for the community to have one contrib instead of two more or less similar (like we have now) and the best place is to have it in SME Contribs.
Title: Re: [ANNOUNCE] smeserver-system_monitor
Post by: okepc on May 13, 2008, 02:08:45 PM
Cactus , mastersleepy has adopted this contrib a long time ago because development stopped of smeserver-sysmon.
Since than i thankfully use mastersleepy's forked contrib!
Now the original writer of smeserver-sysmon started again working on his contrib and has put it in the smecontribs repository.
This conflicted and my sysmon was overwritten with the incorrect one.
The previous author shouldn't have put it in the repository, but should have contacted the forked developer of doin so.

Thanks again mastersleepy for the contrib, it's better than smeserver-sysmon cause it has ups support and samba users etc.

Dirk
Title: Re: [ANNOUNCE] smeserver-system_monitor
Post by: cactus on May 13, 2008, 02:21:29 PM
Cactus , mastersleepy has adopted this contrib a long time ago because development stopped of smeserver-sysmon.
I am not to sure on that, no development does not mean the contrib is not maintained anymore.

Since than i thankfully use mastersleepy's forked contrib!
Now the original writer of smeserver-sysmon started again working on his contrib and has put it in the smecontribs repository.
This conflicted and my sysmon was overwritten with the incorrect one.
The previous author shouldn't have put it in the repository, but should have contacted the forked developer of doin so.
I think this is a wrong assumption, first and foremost I think MasterSleepy should have contacted the original author, state his plans and see what responses would be, perhaps the original author (who is one of the core devs by the way) would have implemented them or asked for a patch, most likely he would not have imported his version into CVS as he would have known that a forked and improved version was available. I still think MasterSleepy should contact the original developer and work out what to do, make him maintainer, preferably in SME Contribs or have his fixed taken up into the one in SME Contribs.

I do not think MasterSleepy should keep the code/coding to himself (most of it is not even his work) as a centralized code storage and build environment improves quality, speed of development and would have prevented troubles like the ones you were experiencing with two trees of development under one package name.

cause it has ups support and samba users etc.
Which could have also been in the one in SME Contribs, as MasterSleepy would have taken the proper path of contacting the original author instead of forking his own copy and releasing that as his work...
Title: Re: [ANNOUNCE] smeserver-system_monitor
Post by: okepc on May 13, 2008, 02:30:12 PM
I agree cactus maybe code should be merged to make the best package.

Quote
I tend to think that you did not do most of the work, but extended the contrib a little bit as your code does not difference that much from the original code now in SME Contribs. Rebranding is not a good option IMHO.

What i wanted to say is that we should be thankful that mastersleepy adopted , forked and improved the code.

Dirk
Title: Re: [ANNOUNCE] smeserver-system_monitor
Post by: MasterSleepy on May 13, 2008, 03:07:36 PM
Sure it should be better to have only one contribs.
Sure it should be better that every body pay attention to other work.

I'll try to make abstraction than original author leave contribs unchanged for ~5 year.

I put it in your respository as soon as I can have access!

MasterSleepy.
Title: Re: [ANNOUNCE] smeserver-system_monitor
Post by: cactus on May 13, 2008, 03:35:25 PM
I put it in your respository as soon as I can have access!
For more information on how to gain access: http://wiki.contribs.org/Package_Modification

I hope we see your contributions in the SME Contribs repository soon.
Title: Re: [ANNOUNCE] smeserver-system_monitor
Post by: Jean-Philippe Pialasse on May 14, 2008, 02:31:52 AM
For more information on how to gain access: http://wiki.contribs.org/Package_Modification

I hope we see your contributions in the SME Contribs repository soon.

or better you can read : http://wiki.contribs.org/Package_Modification/fr

:)

The community really needs to improve communication in both direction . this is not a unique case of misunderstaning about a contrib. Another case is smeserver-fetchmail : and this one was still under active dev and support from its original author. ( and isn't it ironic to see who forked  this contrib into the dev system)

The team really must contact the original author of  a contrib before adding it to a repo. It is nothing a simple mail : 5 minutes of time  to write it few days to wait an answer... and a way to know if the author wants to come in : it is better to have him in to help than to make him disappointed.


On the other side a contribs that seems without update where somebody wants to update it: same thing contact the original author : if he wants to work on it next he will be aware of your work and will be able to start from your revision .


There are email addresses in the SPEC of the RPM this is not for dogs this is for this reason !

[edit] reduced font size
Title: Re: [ANNOUNCE] smeserver-system_monitor
Post by: cactus on May 14, 2008, 05:00:59 PM
The community really needs to improve communication in both direction . this is not a unique case of misunderstaning about a contrib. Another case is smeserver-fetchmail : and this one was still under active dev and support from its original author. ( and isn't it ironic to see who forked  this contrib into the dev system)
And isn't it strange that you are saying communication is needed, while you do not know what has been communicated between the dev team (on behalf of Shad) and the developer of before mentioned contrib? Please do not state things you assume as a fact as they might not be...

Do you also know why contribs are entered in the SME Contribs system? Perhaps you want to think about that for five minutes before posting a message here... as I can think about a handfull:

And you do not have to use such a big size font as I, and many others perhaps as well, consider that quite rude behavior. We know that the e-mailadresses in the SPEC files are e-mailadresses we can contact the authors on and take it from me, those addresses are used to contact authors if needed.
Title: Re: [ANNOUNCE] smeserver-system_monitor
Post by: Jean-Philippe Pialasse on May 14, 2008, 05:39:06 PM
And isn't it strange that you are saying communication is needed, while you do not know what has been communicated between the dev team (on behalf of Shad) and the developer of before mentioned contrib? Please do not state things you assume as a fact as they might not be...
I  know that Sibsib, the original author was not aware of this importation of his code as the first release from Shad was done 1 day after the one SibSib released for utf8 .  Further more I think Shad is enought honest to repeat here what he told me on Skype  when i suggest him to contact contribs author before importing  himself a contrib !

Cactus theses are facts !
you can check the bugtracker about smeserver-fetchmail or refer to alt.e-smith.fr or forums.ixus.fr. Or ask Shad what he thinks about send an email to the last author !

Do you also know why contribs are entered in the SME Contribs system? Perhaps you want to think about that for five minutes before posting a message here...

Cactus I have two of my contribs : smeserver-denyhosts and smeserver-usbdiskmanager on smecontribs so i know the advantages.

I was pleased  to put them on it , and learn new way to work on my contribs to correspond to sme policy. And i thanks Shads and Gavin for their precious time in helping me to do so .

BUT If you want more contributor to join in it is not by ignoring their existence you will have results.


And you do not have to use such a big size font as I, and many others perhaps as well, consider that quite rude behavior.

And how about ignoring people ? It is only five minutes of time to contact the author !

We know that the e-mailadresses in the SPEC files are e-mailadresses we can contact the authors on and take it from me, those addresses are used to contact authors if needed.

and importing their work is not a situation where it is needed ?

A simple email would change the point of view from "they clearly consider they do not need me"  to  "Hey they feel my work is important for SME community let's work with them".

Do you feels like contribs.org team do not need the community ?

Does the team has enought time to maintain on her own all existing contribs, creating new one and updating the sme core ?


Or am I too French ?
Title: Re: [ANNOUNCE] smeserver-system_monitor
Post by: cactus on May 14, 2008, 05:49:53 PM
I  know that Sibsib, the original author was not aware of this importation of his code as the first release from Shad was done 1 day after the one SibSib released for utf8 .  Further more I think Shad is enought honest to repeat here what he told me on Skype  when i suggest him to contact contribs author before importing  himself a contrib
In the past and still it has been suggested that when you write a contrib, you should also subscribe to the devinfo list as well as request a category in the bugtracker, AFAIK the announcement was made here in the forums and on the devinfo list as well. So contrib authors could have been aware of changes. At least Pascal, has informed about it on the devinfo list.

Or am I too French ?
Perhaps, as I can not help noticing that all the contrib authors that are having issues are native French speaking people... :-D
Title: Re: [ANNOUNCE] smeserver-system_monitor
Post by: Jean-Philippe Pialasse on May 14, 2008, 06:37:14 PM
In the past and still it has been suggested that when you write a contrib, you should also subscribe to the devinfo list as well as request a category in the bugtracker, AFAIK the announcement was made here in the forums and on the devinfo list as well. So contrib authors could have been aware of changes. At least Pascal, has informed about it on the devinfo list.

The dev list do not aware  of what contribs is imported  into smecontribs building structure.

Pascal and I where awared thanks to devlist that some changes where needed for ut8. that's all.

So he first decide to do himself the change to his contribs. On my side i decide to join in .


Perhaps, as I can not help noticing that all the contrib authors that are having issues are native French speaking people... :-D

I would be happy to have return from other non english non french speaking, like german contributor. but on another topic.
I still see no update from saco qmhandler ...

I will stop intervention on this subject here as we are a little out of the topic.
Title: Re: [ANNOUNCE] smeserver-system_monitor
Post by: p-jones on May 19, 2008, 12:59:45 PM
What is the difference between this scenario and the scenario that goes with "Backup with Dar" & DAR2 ??

Sure is confusing for the humble end user. Does all this need to be re-wriiten with new package names ?