Koozali.org: home of the SME Server

Obsolete Releases => SME VoIP (Asterisk, SAIL etc) => Topic started by: apmuthu on February 25, 2013, 09:14:46 AM

Title: SAIL code rationalisation
Post by: apmuthu on February 25, 2013, 09:14:46 AM

Up until the SAIL v3.1.0-145 (published), the localvars.php file was included in all places that needed the sqlite connection string for sark.db.

In SAIL v3.1.1-22 (and possibly a few earlier builds), the /opt/sark/generator/extensions.php file conveniently inlines the code into the new PDO () construct doing away with the localvars.php inclusion. The other sibling scripts still include the said file. If we need to change the location of the sark.db or it's name (would the sarkhpe allow it?), it would have to be edited all over the place.

In both SAIL v3.1.1. and 4.0.0, it remains hardcoded in line 879 in /opt/sark/perl/modules/sark/SarkSubs.pm :

Code: [Select]

    $dbh = DBI->connect( "dbi:SQLite:dbname=/opt/sark/db/sark.db","", "", { RaiseError => 1, AutoCommit => 1 });
whilst in SAIL v3.1.0-145 the last parameter AutoCommit => 0. Any reason?